Make sure that private dependencies are correctly found in iDynTreeConfig.cmake when compiling as a static library #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added find_dependency(OsqpEigen) and find_dependency(LibXml2) when iDynTree is compiled as a static library, fixing the use of iDynTree on Windows (#642). To reduce the possible unexpected problems, the automatic set of the `IDYNTREE_USES_<pkg>` CMake variable when the `<pkg>` CMake package is available in the system has been removed for Irrlicht and WORHP, as it was already disabled for ASSIMP and ALGLIB (#642). To use this dependencies it is now compulsory to set manually the `IDYNTREE_USES_<pkg>` variable to `ON`.
traversaro
force-pushed
the
fix-missing-find-dep-in-static
branch
from
142826b
to
3baf020
Compare
This was referenced Jan 26, 2020
S-Dafarra
approved these changes
Jan 26, 2020
GiulioRomualdi
pushed a commit
to GiulioRomualdi/idyntree
that referenced
this pull request
Jan 28, 2020
Added find_dependency(OsqpEigen) and find_dependency(LibXml2) when iDynTree is compiled as a static library, fixing the use of iDynTree on Windows (robotology#642). To reduce the possible unexpected problems, the automatic set of the `IDYNTREE_USES_<pkg>` CMake variable when the `<pkg>` CMake package is available in the system has been removed for Irrlicht and WORHP, as it was already disabled for ASSIMP and ALGLIB (robotology#642). To use this dependencies it is now compulsory to set manually the `IDYNTREE_USES_<pkg>` variable to `ON`.
S-Dafarra
added a commit
to S-Dafarra/bipedal-locomotion-framework
that referenced
this pull request
May 7, 2020
It also change temporarily the module path in order to find packages that may not be available with find_package. See robotology/idyntree#642 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added find_dependency(OsqpEigen) and find_dependency(LibXml2) when iDynTree is compiled as a static library, fixing the use of iDynTree on Windows.
To reduce the possible unexpected problems, the automatic set of the
IDYNTREE_USES_<pkg>CMake variable when the<pkg>CMake package is available in the system hasbeen removed for Irrlicht and WORHP, as it was already disabled for ASSIMP and ALGLIB.
To use this dependencies it is now compulsory to set manually the
IDYNTREE_USES_<pkg>variable toON.This is an hotfix for the problem reported in robotology/unicycle-footstep-planner#33, but the problem has been fixed just for the dependencies that ship their own CMake config files, and so that can be found with
find_dependency(<pkg>)without problems. Fixing the problem for libraries without cmake config files, such as IPOPT, is a bit more complex, as theFindIpopt.cmakefile needs to be installed, andiDynTreeConfig.cmakefille need to be equipped with logic to load it (temporarly) in the CMAKE_CONFIG_PATH to ensure thatfind_dependency(IPOPT)will work as expected. For this reason, this is left to a future PR.